wip: removed AlertReceiverConfig

harmony/src/domain/topology/oberservability/monitoring.rs

@@ -1,6 +1,5 @@
 use async_trait::async_trait;
 
-use dyn_clone::DynClone;
 use std::fmt::Debug;
 use url::Url;
 
@@ -9,7 +8,7 @@ use crate::interpret::InterpretError;
 use crate::{interpret::Outcome, topology::Topology};
 
 /// Represents an entity responsible for collecting and organizing observability data
-/// from various telemetry sources
+/// from various telemetry sources 
 /// A `Monitor` abstracts the logic required to scrape, aggregate, and structure
 /// monitoring data, enabling consistent processing regardless of the underlying data source.
 #[async_trait]
@@ -17,23 +16,16 @@ pub trait Monitor<T: Topology>: Debug + Send + Sync {
     async fn deploy_monitor(
         &self,
         topology: &T,
-        alert_receivers: Vec<Box<dyn AlertReceiver<T>>>,
+        alert_receivers: Vec<AlertReceiver>,
     ) -> Result<Outcome, InterpretError>;
 
     async fn delete_monitor(
         &self,
         topolgy: &T,
-        alert_receivers: Vec<Box<dyn AlertReceiver<T>>>,
+        alert_receivers: Vec<AlertReceiver>,
     ) -> Result<Outcome, InterpretError>;
 }
 
-#[async_trait]
+pub struct AlertReceiver {
-pub trait AlertReceiver<T>: Debug + DynClone + Send + Sync {
-    fn get_alert_receiver_config(&self) -> AlertReceiverConfig;
-}
-
-pub struct AlertReceiverConfig {
     pub receiver_id: String,
-    pub receiver_webhook_url: Option<Url>,
-    pub send_resolved: bool,
 }

harmony/src/modules/monitoring/discord_webhook_sender.rs

@@ -1,12 +1,12 @@
 use async_trait::async_trait;
+use serde_json::Value;
 use url::Url;
 
 use crate::{
     interpret::{InterpretError, Outcome},
-    topology::{
+    topology::
-        K8sAnywhereTopology, Topology,
+        K8sAnywhereTopology
-        oberservability::monitoring::{AlertReceiver, AlertReceiverConfig},
+    ,
-    },
 };
 
 #[derive(Debug, Clone)]
@@ -28,14 +28,15 @@ pub trait DiscordWebhookReceiver {
     ) -> Result<Outcome, InterpretError>;
 }
 
+// trait used to generate alert manager config values impl<T: Topology + AlertManagerConfig> Monitor for KubePrometheus
+pub trait AlertManagerConfig<T> {
+    fn get_alert_manager_config(&self) -> Result<Value, InterpretError>;
+}
+
 #[async_trait]
-impl<T: DiscordWebhookReceiver> AlertReceiver<T> for DiscordWebhookConfig {
+impl<T: DiscordWebhookReceiver> AlertManagerConfig<T> for DiscordWebhookConfig {
-    fn get_alert_receiver_config(&self) -> AlertReceiverConfig {
+    fn get_alert_manager_config(&self) -> Result<Value, InterpretError>{
-        AlertReceiverConfig {
+    todo!()
-            receiver_id: self.name.clone(),
-            receiver_webhook_url: Some(self.webhook_url.clone()),
-            send_resolved: self.send_resolved_notifications.clone(),
-        }
     }
 }
 
@@ -54,3 +55,4 @@ impl DiscordWebhookReceiver for K8sAnywhereTopology {
         todo!()
     }
 }
+