diff --git a/harmony/src/domain/topology/oberservability/monitoring.rs b/harmony/src/domain/topology/oberservability/monitoring.rs index 3cdd1bd..7d65bf2 100644 --- a/harmony/src/domain/topology/oberservability/monitoring.rs +++ b/harmony/src/domain/topology/oberservability/monitoring.rs @@ -19,9 +19,7 @@ pub struct AlertingInterpret { } #[async_trait] -impl, T: Topology + HelmCommand> Interpret - for AlertingInterpret -{ +impl, T: Topology> Interpret for AlertingInterpret { async fn execute( &self, inventory: &Inventory, diff --git a/harmony/src/modules/monitoring/kube_prometheus/helm/kube_prometheus_helm_chart.rs b/harmony/src/modules/monitoring/kube_prometheus/helm/kube_prometheus_helm_chart.rs index c262cae..94440c0 100644 --- a/harmony/src/modules/monitoring/kube_prometheus/helm/kube_prometheus_helm_chart.rs +++ b/harmony/src/modules/monitoring/kube_prometheus/helm/kube_prometheus_helm_chart.rs @@ -198,7 +198,7 @@ prometheus: let alert_manager_yaml = serde_yaml::to_string(&alert_manager_values).expect("Failed to serialize YAML"); - debug!("serialed alert manager: \n {:#}", alert_manager_yaml); + debug!("serialized alert manager: \n {:#}", alert_manager_yaml); values.push_str(&alert_manager_yaml); debug!("full values.yaml: \n {:#}", values); HelmChartScore { diff --git a/harmony/src/modules/monitoring/kube_prometheus/prometheus.rs b/harmony/src/modules/monitoring/kube_prometheus/prometheus.rs index e7ddb9a..554d319 100644 --- a/harmony/src/modules/monitoring/kube_prometheus/prometheus.rs +++ b/harmony/src/modules/monitoring/kube_prometheus/prometheus.rs @@ -41,26 +41,6 @@ impl Installable for Prometheus { } } -// //before we talked about having a trait installable and a trait installer for the topology -// // i feel like that might still be necessary to meet the requirement of inventory and topology on -// // the score.create_interpret().execute(inventory, topology) method -// #[async_trait] -// pub trait Installer { -// async fn install(&self, inventory: &Inventory, sender: Box) -> Result<(), InterpretError>; -// } -// -// #[async_trait] -// impl Installer for K8sAnywhereTopology { -// async fn install( -// &self, -// inventory: &Inventory, -// installable: Box>, -// ) -> Result<(), InterpretError> { -// installable.ensure_installed(inventory, self).await?; -// Ok(()) -// } -// } - #[derive(Debug)] pub struct Prometheus { pub config: Arc>, @@ -103,9 +83,4 @@ impl Prometheus { pub trait PrometheusReceiver: Send + Sync + std::fmt::Debug { fn name(&self) -> String; async fn configure_receiver(&self) -> AlertManagerChannelConfig; - //this probably needs to be a type - //that - //represents - //a - //promtheusreceiver }