chore: reformat & clippy cleanup (#96)

Clippy is now added to the `check` in the pipeline

Co-authored-by: Ian Letourneau <letourneau.ian@gmail.com>
Reviewed-on: #96

opnsense-config-xml/src/data/haproxy.rs

@@ -1,4 +1,3 @@
-use rand;
 use rand::Rng;
 use xml::reader::XmlEvent as ReadEvent;
 use xml::writer::XmlEvent as WriteEvent;
@@ -14,7 +13,7 @@ impl YaDeserializeTrait for HAProxyId {
             ReadEvent::StartElement {
                 name, attributes, ..
             } => {
-                if attributes.len() > 0 {
+                if !attributes.is_empty() {
                     return Err(String::from(
                         "Attributes not currently supported by HAProxyId",
                     ));

opnsense-config-xml/src/data/opnsense.rs

@@ -51,7 +51,7 @@ pub struct OPNsense {
 impl From<String> for OPNsense {
     fn from(content: String) -> Self {
         yaserde::de::from_str(&content)
-            .map_err(|e| println!("{}", e.to_string()))
+            .map_err(|e| println!("{}", e))
             .expect("OPNSense received invalid string, should be full XML")
     }
 }
@@ -59,7 +59,7 @@ impl From<String> for OPNsense {
 impl OPNsense {
     pub fn to_xml(&self) -> String {
         to_xml_str(self)
-            .map_err(|e| error!("{}", e.to_string()))
+            .map_err(|e| error!("{}", e))
             .expect("OPNSense could not serialize to XML")
     }
 }