feat: support new configurable field in dhcp config: filename

harmony/src/domain/topology/ha_cluster.rs

@@ -121,6 +121,9 @@ impl DhcpServer for DummyInfra {
     async fn set_boot_filename(&self, _boot_filename: &str) -> Result<(), ExecutorError> {
         unimplemented!("{}", UNIMPLEMENTED_DUMMY_INFRA)
     }
+    async fn set_filename(&self, _filename: &str) -> Result<(), ExecutorError> {
+        unimplemented!("{}", UNIMPLEMENTED_DUMMY_INFRA)
+    }
     fn get_ip(&self) -> IpAddress {
         unimplemented!("{}", UNIMPLEMENTED_DUMMY_INFRA)
     }

harmony/src/domain/topology/network.rs

@@ -48,6 +48,7 @@ pub trait DhcpServer: Send + Sync {
     async fn list_static_mappings(&self) -> Vec<(MacAddress, IpAddress)>;
     async fn set_next_server(&self, ip: IpAddress) -> Result<(), ExecutorError>;
     async fn set_boot_filename(&self, boot_filename: &str) -> Result<(), ExecutorError>;
+    async fn set_filename(&self, filename: &str) -> Result<(), ExecutorError>;
     fn get_ip(&self) -> IpAddress;
     fn get_host(&self) -> LogicalHost;
     async fn commit_config(&self) -> Result<(), ExecutorError>;

harmony/src/infra/opnsense/dhcp.rs

@@ -69,4 +69,14 @@ impl DhcpServer for OPNSenseFirewall {
 
         Ok(())
     }
+
+    async fn set_filename(&self, filename: &str) -> Result<(), ExecutorError> {
+        {
+            let mut writable_opnsense = self.opnsense_config.write().await;
+            writable_opnsense.dhcp().set_filename(filename);
+            debug!("OPNsense dhcp server set filename {filename}");
+        }
+
+        Ok(())
+    }
 }

harmony/src/modules/dhcp.rs

@@ -18,6 +18,8 @@ pub struct DhcpScore {
     pub host_binding: Vec<HostBinding>,
     pub next_server: Option<IpAddress>,
     pub boot_filename: Option<String>,
+    pub filename: Option<String>,
+    pub filename_ipxe: Option<String>,
 }
 
 impl Score for DhcpScore {
@@ -125,8 +127,21 @@ impl DhcpInterpret {
             None => Outcome::noop(),
         };
 
+        let filename_outcome = match &self.score.filename {
+            Some(filename) => {
+                let dhcp_server = Arc::new(topology.dhcp_server.clone());
+                dhcp_server.set_filename(&filename).await?;
+                Outcome::new(
+                    InterpretStatus::SUCCESS,
+                    format!("Dhcp Interpret Set filename to {filename}"),
+                )
+            }
+            None => Outcome::noop(),
+        };
+
         if next_server_outcome.status == InterpretStatus::NOOP
             && boot_filename_outcome.status == InterpretStatus::NOOP
+            && filename_outcome.status == InterpretStatus::NOOP
         {
             return Ok(Outcome::noop());
         }
@@ -134,8 +149,8 @@ impl DhcpInterpret {
         Ok(Outcome::new(
             InterpretStatus::SUCCESS,
             format!(
-                "Dhcp Interpret Set next boot to {:?} and boot_filename to {:?}",
+                "Dhcp Interpret Set next boot to [{:?}], boot_filename to [{:?}], filename to [{:?}]",
-                self.score.boot_filename, self.score.boot_filename
+                self.score.boot_filename, self.score.boot_filename, self.score.filename
             ),
         ))
     }

harmony/src/modules/okd/bootstrap_dhcp.rs

@@ -41,6 +41,8 @@ impl OKDBootstrapDhcpScore {
                 // router address, this is leaking implementation details
                 Some(topology.router.get_gateway()),
                 Some("bootx64.efi".to_string()),
+                Some(format!("{}:8080/boot.ipxe", topology.router.get_gateway())),
+                Some("undionly.kpxe".to_string()),
             ),
         }
     }

harmony/src/modules/okd/dhcp.rs

@@ -32,7 +32,9 @@ impl OKDDhcpScore {
             dhcp_score: DhcpScore {
                 host_binding,
                 next_server: Some(topology.router.get_gateway()),
-                boot_filename: Some("bootx64.efi".to_string()),
+                boot_filename: None,
+                filename_ipxe: Some(format!("{}:8080/boot.ipxe", topology.router.get_gateway())),
+                filename: Some("undionly.kpxe".to_string()),
             },
         }
     }

opnsense-config-xml/src/data/dhcpd.rs

@@ -22,6 +22,7 @@ pub struct DhcpInterface {
     pub nextserver: Option<String>,
     pub filename64: Option<String>,
     pub filename: Option<String>,
+    pub filenameipxe: Option<String>,
     #[yaserde(rename = "ddnsdomainalgorithm")]
     pub ddns_domain_algorithm: Option<MaybeString>,
     #[yaserde(rename = "numberoptions")]

opnsense-config/src/modules/dhcp.rs

@@ -179,7 +179,21 @@ impl<'a> DhcpConfig<'a> {
 
     pub fn set_boot_filename(&mut self, boot_filename: &str) {
         self.enable_netboot();
-        self.get_lan_dhcpd().filename64 = Some(boot_filename.to_string());
         self.get_lan_dhcpd().bootfilename = Some(boot_filename.to_string());
     }
+
+    pub fn set_filename(&mut self, filename: &str) {
+        self.enable_netboot();
+        self.get_lan_dhcpd().filename = Some(filename.to_string());
+    }
+
+    pub fn set_filename64(&mut self, filename64: &str) {
+        self.enable_netboot();
+        self.get_lan_dhcpd().filename64 = Some(filename64.to_string());
+    }
+
+    pub fn set_filenameipxe(&mut self, filenameipxe: &str) {
+        self.enable_netboot();
+        self.get_lan_dhcpd().filenameipxe = Some(filenameipxe.to_string());
+    }
 }